Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QPG] Update flow for Server init in example apps #21098

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[QPG] Update flow for Server init in example apps #21098

merged 1 commit into from
Jul 27, 2022

Conversation

woody-apple
Copy link
Contributor

Problem

  • Server was initialized in the APP task while other Platform actions were running from the 'CHIP'/platform task.
  • This created threading issues specifically for RejoinExistingMulticastGroups(), called from the Thread manager's _OnPlatformEvent() handling (CHIP task) as it could be called before the server intialized the Fabric list.

Change overview

  • Moving init of Server to a Platform scheduled work. This will put both execution on the same task.
  • Remains to be checked if RejoinExistingMulticastGroups() is actually functional.
  • Updated opening of first advertising for lighting app to not open when part of a fabric.

Testing

  • QPG Lighting app commissioned
  • Application resetted
    ** Possibility for crash before the fix
    ** After fix, no crash seen - init flow runs from same task context (checked with debugger/logging)

@tima-q @web-flow
* Schedule initialisation of Server to not mix with OpenThread Platfo…
48b4802 
…rmEvents (#20733)

* Only open commissioning window when no fabric exists (lighting-app)
@github-actions
Copy link

github-actions bot commented Jul 22, 2022 •
edited
Loading

PR #21098: Size comparison from bcdfbfa to 48b4802

Increases (1 build for esp32)
platform target config section bcdfbfa 48b4802 change % change
esp32 all-clusters-app c3devkit (read only) 1022024 1022026 2 0.0
.flash.text 1022024 1022026 2 0.0
Decreases (3 builds for bl602, cyw30739)
platform target config section bcdfbfa 48b4802 change % change
bl602 lighting-app bl602+rpc .text 1082364 1082360 -4 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581778 581770 -8 -0.0
.app_xip_area 460312 460304 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585974 585966 -8 -0.0
.app_xip_area 465356 465348 -8 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bcdfbfa 48b4802 change % change
bl602 lighting-app bl602 (read/write) 1380538 1380538 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050676 1050676 0 0.0
bl602+rpc (read/write) 1425978 1425978 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082364 1082360 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668199 668199 0 0.0
(read/write) 183144 183144 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88327 88327 0 0.0
.text 579556 579556 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633791 633791 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555916 555916 0 0.0
lock-ftd LP_CC2652R7 (read only) 671291 671291 0 0.0
(read/write) 170228 170228 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594368 594368 0 0.0
lock-mtd LP_CC2652R7 (read only) 653575 653575 0 0.0
(read/write) 183632 183632 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 551912 551912 0 0.0
pump-app LP_CC2652R7 (read only) 680775 680775 0 0.0
(read/write) 161600 161600 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89039 89039 0 0.0
.text 591252 591252 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666551 666551 0 0.0
(read/write) 175944 175944 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84895 84895 0 0.0
.text 581176 581176 0 0.0
shell LP_CC2652R7 (read only) 660674 660674 0 0.0
(read/write) 186172 186172 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85098 0 0.0
.text 575260 575260 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581778 581770 -8 -0.0
.app_xip_area 460312 460304 -8 -0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587678 587678 0 0.0
.app_xip_area 461484 461484 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585974 585966 -8 -0.0
.app_xip_area 465356 465348 -8 -0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087424 1087424 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952136 952136 0 0.0
BRD4161A+rpc (read/write) 1141748 1141748 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989572 989572 0 0.0
BRD4161A+rs911x (read/write) 972604 972604 0 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808872 808872 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1127960 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981580 981580 0 0.0
window-app BRD4161A (read/write) 1080900 1080900 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944112 944112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022024 1022026 2 0.0
(read/write) 1486290 1486290 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216016 216016 0 0.0
.flash.text 1022024 1022026 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075743 0 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246420 246420 0 0.0
.flash.text 1070359 1070359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660496 660496 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583036 583036 0 0.0
lock k32w061+release (read/write) 687500 687500 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609556 609556 0 0.0
linux all-clusters-app debug (read only) 2980537 2980537 0 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265739 265739 0 0.0
.text 2536658 2536658 0 0.0
all-clusters-minimal-app debug (read only) 2826433 2826433 0 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266603 0 0.0
.text 2384370 2384370 0 0.0
bridge-app debug+rpc (read only) 2341153 2341153 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199240 199240 0 0.0
.text 1979602 1979602 0 0.0
chip-tool debug (read only) 10349249 10349249 0 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521813 521813 0 0.0
.text 8373844 8373844 0 0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778876 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457580 457580 0 0.0
.text 7736900 7736900 0 0.0
lighting-app debug+rpc (read only) 2564289 2564289 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214832 214832 0 0.0
.text 2179058 2179058 0 0.0
lock-app debug (read only) 2529281 2529281 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229936 0 0.0
.text 2133746 2133746 0 0.0
ota-provider-app debug (read only) 2332865 2332865 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1964930 1964930 0 0.0
ota-requestor-app debug (read only) 2451321 2451321 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208448 0 0.0
.text 2071266 2071266 0 0.0
shell debug (read only) 2567161 2567161 0 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229042 229042 0 0.0
.text 2180562 2180562 0 0.0
thermostat-no-ble arm64 (read only) 2341052 2341052 0 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139444 139444 0 0.0
.text 1964768 1964768 0 0.0
tv-app debug (read only) 3114913 3114913 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250440 250440 0 0.0
.text 2676050 2676050 0 0.0
tv-casting-app debug (read only) 5368625 5368625 0 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334625 334625 0 0.0
.text 4767474 4767474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448968 2448968 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411612 1411612 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176959 1176959 0 0.0
bss 143068 143068 0 0.0
rodata 142440 142440 0 0.0
text 812580 812580 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157011 1157011 0 0.0
bss 142304 142304 0 0.0
rodata 133972 133972 0 0.0
text 801892 801892 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686564 1686564 0 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526464 1526464 0 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630684 1630684 0 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471304 1471304 0 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550716 1550716 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399640 1399640 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588308 1588308 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432760 1432760 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799404 799404 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567128 567128 0 0.0
lighting-app tlsr9518adk80d (read/write) 819452 819452 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583672 583672 0 0.0

@woody-apple woody-apple merged commit d5c364e into sve Jul 27, 2022
@woody-apple woody-apple deleted the cherry-pick-8548f96327532bedbbe9b14a884e853ec14bb4a2 branch July 27, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @tima-q